Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ACP to pubsub KMS #3206

Merged

Remove Close method of head iterator

5c03868
Select commit
Loading
Failed to load commit list.
Merged

feat: Add ACP to pubsub KMS #3206

Remove Close method of head iterator
5c03868
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 7, 2024 in 0s

77.51% (+0.07%) compared to 6d6c9f2

View this Pull Request on Codecov

77.51% (+0.07%) compared to 6d6c9f2

Details

Codecov Report

Attention: Patch coverage is 67.42857% with 57 lines in your changes missing coverage. Please review.

Project coverage is 77.51%. Comparing base (6d6c9f2) to head (5c03868).

Files with missing lines Patch % Lines
internal/db/collection_retriever.go 47.50% 14 Missing and 7 partials ⚠️
internal/db/db.go 64.00% 6 Missing and 3 partials ⚠️
internal/db/iterator.go 78.57% 6 Missing and 3 partials ⚠️
internal/kms/pubsub.go 75.00% 6 Missing and 3 partials ⚠️
internal/db/errors.go 0.00% 4 Missing ⚠️
node/node.go 57.14% 2 Missing and 1 partial ⚠️
errors/errors.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3206      +/-   ##
===========================================
+ Coverage    77.44%   77.51%   +0.07%     
===========================================
  Files          376      378       +2     
  Lines        34791    34941     +150     
===========================================
+ Hits         26943    27083     +140     
- Misses        6238     6243       +5     
- Partials      1610     1615       +5     
Files with missing lines Coverage Δ
event/event.go 100.00% <ø> (ø)
internal/db/merge.go 80.93% <100.00%> (+0.32%) ⬆️
internal/db/p2p_replicator.go 61.06% <100.00%> (+0.82%) ⬆️
internal/db/permission/check.go 83.33% <ø> (ø)
errors/errors.go 95.00% <0.00%> (-5.00%) ⬇️
node/node.go 57.36% <57.14%> (-0.01%) ⬇️
internal/db/errors.go 60.42% <0.00%> (-0.74%) ⬇️
internal/db/db.go 66.53% <64.00%> (-0.30%) ⬇️
internal/db/iterator.go 78.57% <78.57%> (ø)
internal/kms/pubsub.go 67.71% <75.00%> (+5.54%) ⬆️
... and 1 more

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d6c9f2...5c03868. Read the comment docs.