Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(i): Replace broken DQL link in README #3274

Conversation

amarkpark
Copy link
Contributor

Relevant issue(s)

Resolves #3269

Description

This is a change to update a broken link in the README.
This changes the target URI to point to an extant page in the docs.
FROM:
https://docs.source.network/references/query-specification/query-language-overview
TO:
https://docs.source.network/defradb/references/query-specification/query-language-overview

NO CODE CHANGES

Tasks

  • [NA] I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • [NA] I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

I manually followed the old link and the new link. Old was a broken link. New is a proposed correct link.

Specify the platform(s) on which this was tested:

  • MacOS

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.04%. Comparing base (c7b8b93) to head (0d1258d).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3274      +/-   ##
===========================================
- Coverage    78.09%   78.04%   -0.05%     
===========================================
  Files          382      382              
  Lines        35364    35364              
===========================================
- Hits         27615    27599      -16     
- Misses        6116     6126      +10     
- Partials      1633     1639       +6     
Flag Coverage Δ
all-tests 78.04% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 15 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7b8b93...0d1258d. Read the comment docs.

@shahzadlone shahzadlone changed the title docs: replace broken link to DQL in first paragraph of README docs(i): replace broken DQL link in README Nov 26, 2024
@shahzadlone shahzadlone force-pushed the amarkpark/docs/replace_broken_link_to_DQL branch from c6d305d to 0d1258d Compare November 26, 2024 22:19
@shahzadlone shahzadlone changed the title docs(i): replace broken DQL link in README docs(i): Replace broken DQL link in README Nov 26, 2024
@shahzadlone shahzadlone merged commit 8509211 into sourcenetwork:develop Nov 27, 2024
41 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README has broken link to DQL docs
2 participants