Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i): Aggregate filter returns one result #3316

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

nasdf
Copy link
Member

@nasdf nasdf commented Dec 11, 2024

Relevant issue(s)

Resolves #3313

Description

This PR fixes an issue where aggregate filters would only return one result when the first result did not match.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

Added integration tests.

Specify the platform(s) on which this was tested:

  • MacOS

@nasdf nasdf added the bug Something isn't working label Dec 11, 2024
@nasdf nasdf added this to the DefraDB v0.15 milestone Dec 11, 2024
@nasdf nasdf self-assigned this Dec 11, 2024
Copy link
Contributor

@islamaliev islamaliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 90.95607% with 35 lines in your changes missing coverage. Please review.

Project coverage is 78.11%. Comparing base (648924e) to head (e3b15bc).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
internal/planner/average.go 75.00% 6 Missing and 2 partials ⚠️
internal/planner/max.go 92.79% 6 Missing and 2 partials ⚠️
internal/planner/min.go 92.79% 6 Missing and 2 partials ⚠️
internal/planner/count.go 88.00% 4 Missing and 2 partials ⚠️
internal/planner/sum.go 93.98% 4 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3316      +/-   ##
===========================================
+ Coverage    78.08%   78.11%   +0.03%     
===========================================
  Files          382      382              
  Lines        35412    35448      +36     
===========================================
+ Hits         27651    27688      +37     
+ Misses        6123     6121       -2     
- Partials      1638     1639       +1     
Flag Coverage Δ
all-tests 78.11% <90.96%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/planner/sum.go 85.05% <93.98%> (-0.94%) ⬇️
internal/planner/count.go 93.13% <88.00%> (-1.99%) ⬇️
internal/planner/average.go 82.19% <75.00%> (-2.66%) ⬇️
internal/planner/max.go 90.50% <92.79%> (-1.36%) ⬇️
internal/planner/min.go 90.50% <92.79%> (-1.36%) ⬇️

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 648924e...e3b15bc. Read the comment docs.

@nasdf nasdf merged commit e1502c5 into sourcenetwork:develop Dec 11, 2024
42 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter on aliased aggregate doesn't always work
2 participants