Make hop pass through error #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iBotPeaches
approved these changes
Nov 4, 2024
iBotPeaches
requested review from
jyann,
jweberst,
Jasonej,
Bankamah and
nemanjar7
Bankamah
approved these changes
Nov 4, 2024
Jasonej
approved these changes
Nov 4, 2024
nemanjar7
approved these changes
Nov 4, 2024
jweberst
approved these changes
Nov 4, 2024
jyann
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a hop command fails, it will exit with success rather than the original error code. This isn't an issue in most cases since we don't use it in scripts or CI, but it's still helpful to pass any error codes up so multiple commands run with
&&don't continue down the chain.