Fix Windows & MacOS GH CI testing #144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
detjensrobert
force-pushed
the
detjensrobert/gh-actions-fix
branch
from
0f2ae04 to
cbccc11
Compare
detjensrobert
changed the title
detjensrobert
added
the
Release: Patch
detjensrobert
force-pushed
the
detjensrobert/gh-actions-fix
branch
from
f1d857b to
5687864
Compare
damacus
reviewed
Aug 4, 2021
|
Looks like the Windows CI test is failing due to https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands before even getting to the integration converge. |
Would you mind temporarily using your branch here so we can see the fix in action? |
|
Actions fix merged. |
Since these VMs don't need to reboot, run directly on the runner instead of using a nested VM. Signed-off-by: Robert Detjens <[email protected]>
Signed-off-by: Robert Detjens <[email protected]>
Signed-off-by: Robert Detjens <[email protected]>
Signed-off-by: Robert Detjens <[email protected]>
Co-authored-by: Dan Webb <[email protected]>
ramereth
force-pushed
the
detjensrobert/gh-actions-fix
branch
from
348d31c to
9738cbd
Compare
damacus
removed
the
Release: Patch
Signed-off-by: Dan Webb <[email protected]>
Signed-off-by: Dan Webb <[email protected]>
|
I'm working on resolving this in #146 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since these VMs don't need to reboot, run tests directly on the runner instead of using a nested VM.
This should fix the testing failures with the Windows and MacOS testing from #143.
Signed-off-by: Robert Detjens [email protected]
Check List