Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Which for HomebrewUserWrapper #184

Merged
merged 4 commits into from
May 7, 2024

Conversation

jazaval
Copy link
Contributor

@jazaval jazaval commented May 6, 2024

Description

Explicitly include Which module from Chef which fixes cookbook use on newer 18.x clients.

Issues Resolved

Fixes #183

Check List

  • [✅] A summary of changes made is included in the CHANGELOG under ## Unreleased
  • [❌] New functionality includes testing.
  • [❌] New functionality has been documented in the README if applicable.

@jazaval jazaval requested a review from a team as a code owner May 6, 2024 18:00
CHANGELOG.md Outdated Show resolved Hide resolved
metadata.rb Outdated Show resolved Hide resolved
@Stromweld Stromweld added the Release: Patch Release to Chef Supermarket as a version patch when merged label May 6, 2024
@Stromweld
Copy link

Users should be using the built in homebrew resources for chef-client > 14. Not sure what this fix is needed for?

@jazaval
Copy link
Contributor Author

jazaval commented May 7, 2024

Chef client won't install homebrew itself, which is generally the core remaining use here (default recipe).

Copy link

@Stromweld Stromweld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Stromweld Stromweld merged commit 50e29b9 into sous-chefs:main May 7, 2024
9 of 10 checks passed
@kitchen-porter
Copy link
Contributor

Released as: 5.4.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release: Patch Release to Chef Supermarket as a version patch when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

undefined method `which' for #<HomebrewUserWrapper:0x000000010b9f6a58>
3 participants