Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created web frontend launched via --web flag #1967

Merged
merged 15 commits into from
Dec 16, 2024
Merged

Conversation

overcuriousity
Copy link
Contributor

I created a simple lightweight flask frontend.
This is a draft and will receive the additional commandline flags as options.

Frontend can be launched by specifying --web to the launching command, with optional port.

Creates all of the export options and offers them as download, created the graph and embeds it to the results page.

If not merged, I will possibly maintain a fork. I think its lightweight enough to be merged.

Feedback approved.

@overcuriousity overcuriousity marked this pull request as draft December 14, 2024 11:20
@overcuriousity overcuriousity marked this pull request as ready for review December 14, 2024 11:23
@soxoj
Copy link
Owner

soxoj commented Dec 14, 2024

Wow, that's amazing! Of course, I will merge it!
I couldn't get around to this for many years, but you've finally done it.
Thank you so much! ❤️ 🚀

I'll squash and merge it later. The only thing I see that needs fixing is adding a new argument to the tests in test_cli, so all checks pass successfully. I can create a PR with this fix for your fork later, but you can probably address it more quickly.

@overcuriousity
Copy link
Contributor Author

Very happy to see my PR seems useful to you!

I can see from the sourcecode how much effort is going into this and would be happy to participate.

Doing so, I will do some further PRs on the webinterface, but unfortunately am not familiar with the pytest and poetry sections.

@soxoj
Copy link
Owner

soxoj commented Dec 15, 2024

Ok, I fixed tests, please, merge this PR into your repo: overcuriousity#3

@overcuriousity
Copy link
Contributor Author

merged your PR, but had to add a critical bugfix (webinterface launching always without arg).
test_cli.py was adjusted with "None" default argument for the --web flag and passes.

@soxoj
Copy link
Owner

soxoj commented Dec 16, 2024

Great, thanks, let's merge it! I've created a task for documentation for the web interface, to not forget: #1971

@soxoj soxoj merged commit 88d6849 into soxoj:main Dec 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants