Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust crate thiserror to v2 #63

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 7, 2024

This PR contains the following updates:

Package Type Update Change
thiserror dependencies major 1.0.59 -> 2.0.0

Release Notes

dtolnay/thiserror (thiserror)

v2.0.3

Compare Source

  • Support the same Path field being repeated in both Debug and Display representation in error message (#​383)
  • Improve error message when a format trait used in error message is not implemented by some field (#​384)

v2.0.2

Compare Source

  • Fix hang on invalid input inside #[error(...)] attribute (#​382)

v2.0.1

Compare Source

  • Support errors that contain a dynamically sized final field (#​375)
  • Improve inference of trait bounds for fields that are interpolated multiple times in an error message (#​377)

v2.0.0

Compare Source

Breaking changes

  • Referencing keyword-named fields by a raw identifier like {r#type} inside a format string is no longer accepted; simply use the unraw name like {type} (#​347)

    This aligns thiserror with the standard library's formatting macros, which gained support for implicit argument capture later than the release of this feature in thiserror 1.x.

    #[derive(Error, Debug)]
    #[error("... {type} ...")]  // Before: {r#type}
    pub struct Error {
        pub r#type: Type,
    }
  • Trait bounds are no longer inferred on fields whose value is shadowed by an explicit named argument in a format message (#​345)

    // Before: impl<T: Octal> Display for Error<T>
    // After: impl<T> Display for Error<T>
    #[derive(Error, Debug)]
    #[error("{thing:o}", thing = "...")]
    pub struct Error<T> {
        thing: T,
    }
  • Tuple structs and tuple variants can no longer use numerical {0} {1} access at the same time as supplying extra positional arguments for a format message, as this makes it ambiguous whether the number refers to a tuple field vs a different positional arg (#​354)

    #[derive(Error, Debug)]
    #[error("ambiguous: {0} {}", $N)]
    //                  ^^^ Not allowed, use #[error("... {0} {n}", n = $N)]
    pub struct TupleError(i32);
  • Code containing invocations of thiserror's derive(Error) must now have a direct dependency on the thiserror crate regardless of the error data structure's contents (#​368, #​369, #​370, #​372)

Features

  • Support disabling thiserror's standard library dependency by disabling the default "std" Cargo feature: thiserror = { version = "2", default-features = false } (#​373)

  • Support using r#source as field name to opt out of a field named "source" being treated as an error's Error::source() (#​350)

    #[derive(Error, Debug)]
    #[error("{source} ==> {destination}")]
    pub struct Error {
        r#source: char,
        destination: char,
    }
    
    let error = Error { source: 'S', destination: 'D' };
  • Infinite recursion in a generated Display impl now produces an unconditional_recursion warning (#​359)

    #[derive(Error, Debug)]
    #[error("??? {self}")]
    pub struct Error;
  • A new attribute #[error(fmt = path::to::myfmt)] can be used to write formatting logic for an enum variant out-of-line (#​367)

    #[derive(Error, Debug)]
    pub enum Error {
        #[error(fmt = demo_fmt)]
        Demo { code: u16, message: Option<String> },
    }
    
    fn demo_fmt(code: &u16, message: &Option<String>, formatter: &mut fmt::Formatter) -> fmt::Result {
        write!(formatter, "{code}")?;
        if let Some(msg) = message {
            write!(formatter, " - {msg}")?;
        }
        Ok(())
    }
  • Enums with an enum-level format message are now able to have individual variants that are transparent to supersede the enum-level message (#​366)

    #[derive(Error, Debug)]
    #[error("my error {0}")]
    pub enum Error {
        Json(#[from] serde_json::Error),
        Yaml(#[from] serde_yaml::Error),
        #[error(transparent)]
        Other(#[from] anyhow::Error),
    }

Configuration

📅 Schedule: Branch creation - "* 0-3 * * *" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from maxhoesel as a code owner November 7, 2024 00:43
@renovate renovate bot added the pr-deps Pull requests that update a dependency file label Nov 7, 2024
Copy link
Contributor Author

renovate bot commented Nov 7, 2024

⚠️ Artifact update problem

Renovate failed to update artifacts related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: Cargo.lock
Command failed: cargo update --config net.git-fetch-with-cli=true --manifest-path crates/k8s/Cargo.toml --package [email protected] --precise 2.0.7
    Updating crates.io index
error: failed to select a version for the requirement `thiserror = "^1.0.21"`
candidate versions found which didn't match: 2.0.7
location searched: crates.io index
required by package `quinn v0.11.2`
    ... which satisfies dependency `quinn = "^0.11.1"` (locked to 0.11.2) of package `reqwest v0.12.9`
    ... which satisfies dependency `reqwest = "^0.12.4"` (locked to 0.12.9) of package `metallb-dyn6-sources v0.1.2 (/tmp/renovate/repos/github/spacebird-dev/metallb-dyn6/crates/sources)`
    ... which satisfies path dependency `metallb-dyn6-sources` (locked to 0.1.2) of package `metallb-dyn6 v0.1.2 (/tmp/renovate/repos/github/spacebird-dev/metallb-dyn6/crates/cli)`

File name: Cargo.lock
Command failed: cargo update --config net.git-fetch-with-cli=true --manifest-path crates/sources/Cargo.toml --package [email protected] --precise 2.0.7
    Updating crates.io index
error: failed to select a version for the requirement `thiserror = "^1.0.21"`
candidate versions found which didn't match: 2.0.7
location searched: crates.io index
required by package `quinn v0.11.2`
    ... which satisfies dependency `quinn = "^0.11.1"` (locked to 0.11.2) of package `reqwest v0.12.9`
    ... which satisfies dependency `reqwest = "^0.12.4"` (locked to 0.12.9) of package `metallb-dyn6-sources v0.1.2 (/tmp/renovate/repos/github/spacebird-dev/metallb-dyn6/crates/sources)`
    ... which satisfies path dependency `metallb-dyn6-sources` (locked to 0.1.2) of package `metallb-dyn6 v0.1.2 (/tmp/renovate/repos/github/spacebird-dev/metallb-dyn6/crates/cli)`

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.18%. Comparing base (b1680b3) to head (9950334).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #63   +/-   ##
=======================================
  Coverage   71.18%   71.18%           
=======================================
  Files           9        9           
  Lines         472      472           
=======================================
  Hits          336      336           
  Misses        136      136           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renovate renovate bot force-pushed the renovate/thiserror-2.x branch 4 times, most recently from 3834941 to a45b1a3 Compare November 12, 2024 05:01
@renovate renovate bot force-pushed the renovate/thiserror-2.x branch 3 times, most recently from a70af66 to 60da3f9 Compare November 21, 2024 04:25
@renovate renovate bot force-pushed the renovate/thiserror-2.x branch 5 times, most recently from 8c922e1 to 7f229a7 Compare December 5, 2024 03:58
@renovate renovate bot force-pushed the renovate/thiserror-2.x branch 2 times, most recently from a2840f5 to 869014d Compare December 12, 2024 03:12
@renovate renovate bot force-pushed the renovate/thiserror-2.x branch from 869014d to 9950334 Compare December 16, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-deps Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants