Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on spectral-cube and parse ASDF/GWCS for JWST s3d cube #1003

Closed
wants to merge 2 commits into from

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Dec 14, 2021

Description

This pull request is to remove dependency on spectral-cube and parse ASDF/GWCS for JWST s3d cube.

Blocked by:

Path forward:

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a change log needed? If yes, is it added to CHANGES.rst?
  • Is a milestone set? Milestone is only currently required for PRs related to Imviz MVP.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

and parse ASDF/GWCS for JWST s3d cube.
@pllim pllim added this to the 2.2 milestone Dec 14, 2021
@github-actions github-actions bot added cubeviz documentation Explanation of code and concepts testing labels Dec 14, 2021
@pllim pllim closed this Dec 14, 2021
@pllim pllim deleted the cubeviz-parser-asdf-gwcs branch December 14, 2021 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cubeviz documentation Explanation of code and concepts testing
Projects
None yet
1 participant