-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Re-enable test_moment_maps #1024
Conversation
This comment has been minimized.
This comment has been minimized.
I also noticed a lot of this:
I suspect there are some unnecessary data translation going on in the background but fixing that is out of scope here. |
Codecov Report
@@ Coverage Diff @@
## main #1024 +/- ##
==========================================
+ Coverage 72.69% 73.09% +0.40%
==========================================
Files 75 75
Lines 5669 5669
==========================================
+ Hits 4121 4144 +23
+ Misses 1548 1525 -23
Continue to review full report at Codecov.
|
jdaviz/configs/cubeviz/plugins/moment_maps/tests/test_moment_maps.py
Outdated
Show resolved
Hide resolved
jdaviz/configs/cubeviz/plugins/moment_maps/tests/test_moment_maps.py
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
dc92c56
to
a32ddca
Compare
result = dc[1].get_object(cls=CCDData) | ||
assert result.shape == (4, 2) | ||
|
||
# FIXME: Need spatial WCS, see https://github.com/spacetelescope/jdaviz/issues/1025 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xref #1025
Description
This pull request is to re-enable and fix a failing test.
Fixes #948
Follow-up of #547
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.CHANGES.rst
?