Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cubeviz image viewer to display coords for 2D data #1326

Merged
merged 1 commit into from
May 18, 2022

Conversation

javerbukh
Copy link
Contributor

@javerbukh javerbukh commented May 17, 2022

Description

This pull request is to address the cubeviz coords display failing for 2D data in the image viewer.

This is a direct follow-up of #1315

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides? N/A
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a change log needed? If yes, is it added to CHANGES.rst?
  • Is a milestone set?
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@javerbukh javerbukh added bug Something isn't working no-changelog-entry-needed changelog bot directive labels May 17, 2022
@pllim pllim added this to the 2.6 milestone May 17, 2022
@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #1326 (ce25f7f) into main (bfa615e) will decrease coverage by 0.19%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main    #1326      +/-   ##
==========================================
- Coverage   83.92%   83.73%   -0.20%     
==========================================
  Files          91       91              
  Lines        7622     7754     +132     
==========================================
+ Hits         6397     6493      +96     
- Misses       1225     1261      +36     
Impacted Files Coverage Δ
jdaviz/configs/cubeviz/plugins/viewers.py 85.41% <60.00%> (-1.69%) ⬇️
...s/default/plugins/model_fitting/fitting_backend.py 77.90% <0.00%> (-15.12%) ⬇️
...configs/default/plugins/data_tools/file_chooser.py 65.71% <0.00%> (-3.43%) ⬇️
jdaviz/configs/imviz/plugins/tools.py 42.74% <0.00%> (-1.92%) ⬇️
jdaviz/configs/specviz/plugins/viewers.py 83.07% <0.00%> (+0.13%) ⬆️
jdaviz/core/marks.py 89.78% <0.00%> (+5.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfa615e...ce25f7f. Read the comment docs.

Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think this might be correct, at least X and Y seems sensible when I tested with the data from here:

If we see weird behavior due to WCS swapping in some other data, we can deal with it later. Thanks for fixing my bug!

@pllim pllim added the trivial Only needs one approval instead of two label May 18, 2022
@pllim pllim merged commit 9213765 into spacetelescope:main May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cubeviz no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants