Code

Add API to rename subsets#3356

Code

Merged

rosteen merged 37 commits intospacetelescope:mainspacetelescope/jdaviz:mainfrom rosteen:rename-subsets-apirosteen/jdaviz:rename-subsets-apiCopy head branch name to clipboardDec 30, 2024

+294-24

Commits

Commits on Dec 23, 2024

• adding check for subset name

  

  cshanahan1

  authored and

  rosteen

  committed
  644c6fa

• Create list of reserved labels at app level to check against

  rosteen

  committed
  33c29a4

• Force labels to strings now so don't need None

  rosteen

  committed
  d276f7c

• Move validation function, minimize layer reprocessing, start adding to subset_tools

  rosteen

  committed
  8a760f9

• Warn if label is not alphanumberic, adding code from spacetelescope#1291

  Show description for 354d9f8
  

  rosteen

  and

  kecnry

  committed
  354d9f8

• Add SubsetRenameMessage

  rosteen

  committed
  68bcf15

• Update all SubsetSelects in plugins when subset is renamed.

  rosteen

  committed
  fa75705

• allow plugin components to call send_state

  Show description for ff18e05
  

  kecnry

  authored and

  rosteen

  committed
  ff18e05

• Working on updating subset items in LayerSelect on rename, buggy right now

  rosteen

  committed
  dafdd7c

• Add passing test, refactor app.get_subsets for better efficiency in single subset case

  rosteen

  committed
  5bf5c72

• Add changelog

  rosteen

  committed
  9ce2c0d

• Remove leftover lower() from rebase

  rosteen

  committed
  b1afe39

• Fix tests

  rosteen

  committed
  7b7466f

• Remove debugging prints

  rosteen

  committed
  575bdee

• Add docstrings, remove kwarg that isn't relevant to users

  rosteen

  committed
  394afd0

• Don't allow renaming to Subset N

  rosteen

  committed
  6eb5156

• Raise instead of error, add test

  rosteen

  committed
  1a195ae

• Remove debugging prints

  rosteen

  committed
  2aa8afc

• Raise error if trying to rename a subset that doesn't exist

  rosteen

  committed
  c1c857d

• Remove prints

  rosteen

  committed
  f579ab1

• codesty.e

  rosteen

  committed
  ecdaf94

Commits on Dec 24, 2024

• Don't check for hardcoded 'Subset' in label

  rosteen

  committed
  03ba4ce

• Fix failing test

  rosteen

  committed
  4e1a694

• Fix check to be more general

  rosteen

  committed
  79ee99a

• Move changelog entry

  rosteen

  committed
  4c431a9

Commits on Dec 26, 2024

• Restore updated subset to layer select menus with icon

  rosteen

  committed
  fe0f198

• Don't duplicate renamed subset in export plugin

  rosteen

  committed
  5b69487

• Update extracted spectrum data collection item as well

  Show description for 70d4058
  rosteen

  committed
  70d4058

• Update old data menu items

  rosteen

  committed
  5e4b424

Commits on Dec 27, 2024

• Address review comments

  rosteen

  committed
  2f35bc1

• Codestyle

  rosteen

  committed
  1f1978e

• Check old label

  rosteen

  committed
  cbc0698

• Add simple test

  rosteen

  committed
  c64656e

• Test rename_selected

  rosteen

  committed
  cf79558

• Codestyle

  rosteen

  committed
  8e95d39

• Cover another case

  rosteen

  committed
  851f200

Commits on Dec 30, 2024

• Add methods to class docstring

  rosteen

  committed
  0d74275