Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use write locks in license store to avoid deadlocks #251

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

goneall
Copy link
Member

@goneall goneall commented Sep 11, 2024

Fixes #250

Copy link
Collaborator

@pmonks pmonks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't run into this issue myself, so my familiarity with it is minimal, but this change looks fairly innocuous, and all of the unit tests pass for me locally (including the slow tests).

Given the potential for decreased performance in concurrent scenarios (and the fact that such aspects are difficult to test via unit tests), I'd suggest that this change be released in an alpha, beta, release candidate or similar, so that it can be tested in real world scenarios by consumers of the library (and given how large of a change v2.0.0 is, this is probably a good idea more generally anyway).

@goneall
Copy link
Member Author

goneall commented Nov 7, 2024

I'll go ahead and merge this in so it can get some early testing with the 2.0 spec updates.

@goneall goneall merged commit f483016 into master Nov 7, 2024
1 check passed
@goneall goneall deleted the writelocks branch November 7, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deadlock in ListedLicenseWebStore
2 participants