Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes many bugs with curves #151

Merged
merged 6 commits into from
Mar 9, 2023
Merged

Fixes many bugs with curves #151

merged 6 commits into from
Mar 9, 2023

Conversation

JR-Morgan
Copy link
Member

@JR-Morgan JR-Morgan commented Feb 20, 2023

  • Several improvements to NURBS conversion ToNative and ToSpeckle
  • Added displayValue for nurbs curves so that they can now display in the viewer.
  • Added Ellipse & Circle to native (Bézier) conversion

Before:
image

After:
image

Truth:
image

see #131

@JR-Morgan JR-Morgan marked this pull request as ready for review February 21, 2023 19:31
@JR-Morgan JR-Morgan linked an issue Feb 23, 2023 that may be closed by this pull request
@JR-Morgan JR-Morgan linked an issue Feb 27, 2023 that may be closed by this pull request
@JR-Morgan JR-Morgan merged commit ebb4e32 into main Mar 9, 2023
@JR-Morgan JR-Morgan deleted the jrm/curve-fix branch March 9, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

➰ Sent Bézier curve are missing DisplayValues ➰ Improve curve conversions
1 participant