Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(objectsender): expose all options to allow configuration #2751

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

iainsproat
Copy link
Contributor

@iainsproat iainsproat commented Aug 24, 2024

Description & motivation

The transport and serializer for objectsender can be configured using options. These are now exposed to callers of the objectsender to allow full customization.

Changes:

  • objectsender transport options can be configured
  • objectsender serializer options can be configured
  • objectsender transport & serializer constructors now use a parameter object to allow for more flexibility to add or amend parameters in the future without incurring further breaking changes.

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@iainsproat iainsproat marked this pull request as ready for review August 24, 2024 11:15
@gjedlicska
Copy link
Contributor

What is the goal here @iainsproat?

@iainsproat
Copy link
Contributor Author

What is the goal here @iainsproat?

A response to this community post: https://speckle.community/t/is-there-a-rate-limit-on-post-objects-projectid/12310/20?u=iainsproat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants