fix(automate): automate module multi region #3531
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…com:specklesystems/speckle-server into chuck/web-2150-automate-module-multi-region
…chuck/web-2150-automate-module-multi-region
alemagio
requested changes
Nov 22, 2024
| @@ -21,27 +19,30 @@ import { Application } from 'express' | |||
|
|
|||
| export default (app: Application) => { | |||
| app.get( | |||
| '/api/automate/automations/:automationId/runs/:runId/logs', | |||
| '/api/v1/projects/:projectId/automations/:automationId/runs/:runId/logs', | |||
There was a problem hiding this comment.
is it fine breaking this API?
There was a problem hiding this comment.
yes, its only the frontend, that uses this api and that should have been updated in this pr right @cdriesler?
There was a problem hiding this comment.
yes has been adjusted to reflect this 👍
packages/server/package.json
Outdated
| @@ -22,7 +22,7 @@ | |||
| "build:clean": "rimraf ./dist && yarn build", | |||
| "dev:clean": "yarn build:clean && yarn dev", | |||
| "dev:server:test": "cross-env DISABLE_NOTIFICATIONS_CONSUMPTION=true NODE_ENV=test LOG_LEVEL=silent LOG_PRETTY=true node ./bin/ts-www", | |||
| "test": "cross-env NODE_ENV=test LOG_LEVEL=silent LOG_PRETTY=true mocha", | |||
| "test": "cross-env NODE_ENV=test LOG_PRETTY=true mocha", | |||
There was a problem hiding this comment.
did you remove the LOG_LEVEL=silent?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Changes:
how to count automations a function is used in (requires counting in all regions) (or just deleting this capability?)how to find project based on function run id (status reporting from automate)reportFunctionRunStatusmutation, depends on following changes:Confirmed triggers work, automations can be queried, and functions/reconciler can report results with the user-facing api changes.