Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the asr-metrics dependencies into a 'extra' set of dependencies #108

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JamesG-Speechmatics
Copy link
Contributor

Installing numpy and other large libraries is not necessary if only doing realtime speech recognition. This MR moves the dependencies of asr_metrics into a larger version of the package to be installed as

pip3 install speechmatics-python[full]

todo: code in asr_metrics to fail gracefully on import error.

Because this is a breaking change for anyone who does use asr_metrics, the major version is bumped from 2 to 3.

@JamesG-Speechmatics
Copy link
Contributor Author

todo: code in asr_metrics to fail gracefully on import error.

This would be a nice to do but I don't have time to do it and test it for the different metrics scripts, it would be something like

try:
  import things
except ImportError:
  # write message about speechmatics-python[full]

in the right places (the file where main() is defined I suppose). @dan-cochrane

@dan-cochrane
Copy link
Contributor

dan-cochrane commented Dec 18, 2024

Didn't see this PR @JamesG-Speechmatics, sorry about that.

I'm happy to pick up some of those changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants