Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry on protocol error #73

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Retry on protocol error #73

merged 3 commits into from
Oct 19, 2023

Conversation

anjz
Copy link
Contributor

@anjz anjz commented Oct 18, 2023

In certain rare situations httpx raises ProtocolError making requests to the batch API. A retry mitigates the problem.

@anjz anjz marked this pull request as draft October 18, 2023 09:26
@anjz anjz marked this pull request as ready for review October 18, 2023 14:05
@anjz anjz requested review from TudorCRL, HennerM and dumitrugutu and removed request for TudorCRL October 19, 2023 12:09
Copy link
Collaborator

@HennerM HennerM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

anjz added 3 commits October 19, 2023 17:11
…xception. Prevents failures in rare events in which the server response causes httpx to raise protocol error
@anjz anjz force-pushed the fix/protocol-error branch from aaf1b0e to 856fef4 Compare October 19, 2023 16:12
@anjz anjz merged commit c8b7376 into master Oct 19, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants