Qt6 #8545
Merged
Qt6 #8545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SomberNight
reviewed
Jul 19, 2023
SomberNight
reviewed
Jul 19, 2023
2 tasks
Khademr7
approved these changes
Jul 21, 2023
SomberNight
reviewed
Aug 30, 2023
SomberNight
added a commit
that referenced
this pull request
Aug 30, 2023
taken from #8545 22bfd4e note: com.android.support is used in our p4a fork's PythonActivity.java (com.android.support was previously pulled in by me.dm7.barcodescanner) https://github.com/accumulator/python-for-android/blob/052b9f7945bae557347fa4a4b418040d9da9eaff/pythonforandroid/bootstraps/qt5/build/src/main/java/org/kivy/android/PythonActivity.java#L43
Merged
accumulator
force-pushed
the
qt6
branch
6 times, most recently
from
94ba1b2
to
2aa7565
Compare
SomberNight
reviewed
Oct 5, 2023
3 tasks
accumulator
force-pushed
the
qt6
branch
3 times, most recently
from
ea6fc08
to
d4871f7
Compare
SomberNight
reviewed
Oct 24, 2023
electrum/gui/qml/java_classes/org/electrum/qr/SimpleScannerActivity.java
Show resolved
Hide resolved
SomberNight
reviewed
Oct 30, 2023
|
removing Draft status, as there are currently no open issues and this PR can be reviewed as is. before considering merging, the build container name change commit should be removed first. |
SomberNight
reviewed
Oct 31, 2023
SomberNight
reviewed
Oct 31, 2023
buildozer ref to 698b48136c55b2495128207c5e98dccc128bb6c2
…dicators toggle visibility
As the method of capturing frames is totally different, the animation when a QR is found has been removed.
…ith simple properties
…y for android only. Also use stable R package, regardless of APP_PACKAGE_DOMAIN used in build.
turns out that Qt.inputMethod.keyboardRectangle.height is not suitable for calculating the exact keyboard dimensions in Qt coordinates. Instead, use Qt.inputMethod.keyboardRectangle.y transformed to Qt coordinates using Screen.devicePixelRatio Note: Qt.inputMethod.keyboardRectangle stop being updated after exiting FLAG_SECURE state (e.g. in seed or master key entry pages)
|
rebased and removed the commit changing the qt6 specific build image name, so this PR should be ready to merge. (build container name change parked in https://github.com/accumulator/electrum/tree/qt6-tmp if you need it) |
Doesn't really work as it triggers on events above the background it is defined on :(
SomberNight
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
I have tried to review and test this now (at commit 047cc6f), and to me it looks good.
Thank you very much for this work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently builds a working APK using buildozer HEAD and python-for-android HEAD plus a patchset for qt6 bootstrap and pyqt6.
Builds against API 31, NDK 23c
Additional notes:
build container name temporarily renamed so it's easier to switch between current qt5 and this qt6 buildPillowdependency is upped to 8.4.0 for PyQt6 supportIssues
SimpleScannerActivityon android platform.