Do not panic on passing empty tar reader to tarfs

Corrects a bug where passing an empty tar reader to tarfs would cause adding the pseudoroot to panic with assignment to entry in nil map. Signed-off-by: hasheddan <[email protected]>
spf13 · Oct 5, 2020 · 9fa7c3b · 9fa7c3b
1 parent a4ea980
commit 9fa7c3b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/tarfs/fs.go b/tarfs/fs.go
@@ -63,6 +63,9 @@ func New(t *tar.Reader) *Fs {
 
 	}
 
+	if fs.files[afero.FilePathSeparator] == nil {
+		fs.files[afero.FilePathSeparator] = make(map[string]*File)
+	}
 	// Add a pseudoroot
 	fs.files[afero.FilePathSeparator][""] = &File{
 		h: &tar.Header{

diff --git a/tarfs/tarfs_test.go b/tarfs/tarfs_test.go
@@ -9,6 +9,7 @@ import (
 	"os"
 	"path/filepath"
 	"reflect"
+	"strings"
 	"syscall"
 	"testing"
 
@@ -54,6 +55,9 @@ func TestMain(m *testing.M) {
 
 	tfs := New(tar.NewReader(tf))
 	afs = &afero.Afero{Fs: tfs}
+
+	// Check that an empty reader does not panic.
+	_ = New(tar.NewReader(strings.NewReader("")))
 	os.Exit(m.Run())
 }