Use SVG format for generating images to embed into the RST prior to rst2pdf creating a PDF #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st2pdf creating a PDF
|
If the original behaviour should remain as default, then I can update this to use a config flag for setting the rendering output for the images. |
yuja
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code would generate an EPS and PDF file for each PlantUML and them embed them as PDFs into the RST before processing through rst2pdf to generate the PDF. However, rst2pdf doesn't appear to support PDFs embedded as images into the RST.
So, changing to SVG.
Unless someone can show me how to get the PDF to work with rst2pdf. I tried it directly and it wouldn't take it.