Fixed the issue of IP resources being exhausted when using multiple NICs

[ty-dc]

Thanks for contributing!

Notice:

• unite test or E2E test
• do not forget essential code comment and log
• document for the PR
• release note label
  "release/none"
  "release/bug"
  "release/feature"
• read about Contribution notice: https://spidernet-io.github.io/spiderpool/latest/develop/contributing/

What issue(s) does this PR fix:

Fixes #

Special notes for your reviewer:

Problem 1:

When ipam.spidernet.io/ippools does not specify an interface name, the network card information recorded in spiderEndpoint is incorrect.

Especially for statefulset applications, if interface is equal to "", the endpoint will be deleted.

  current:
    ips:
    - cleanGateway: false
      interface: eth0
      ipv4: 172.18.40.5/16
      ipv4Gateway: 172.18.0.1
      ipv4Pool: default-v4-ippool
      vlan: 0
    - cleanGateway: false
      interface: ""
      ipv4: 172.20.40.200/16
      ipv4Gateway: 172.20.0.1
      ipv4Pool: test-v4-ippool
      vlan: 0

Problem 2:

IP ​​resources are exhausted，The 4102bd95-8f63-4f66-9b64-d7050e91b6c5 UID occupies IP resources indefinitely.

kubectl get sp default-v4-ippool -ojsonpath={.status.allocatedIPs} | jq 
{
  "172.18.40.10": {
    "pod": "default/ippool-test-app-58b7766c7c-mvwpf",
    "podUid": "4009cb83-bd17-4b08-92f0-2ea0cd3d64fc"
  },
  "172.18.40.11": {
    "pod": "default/ippool-test-app-58b7766c7c-5jp5d",
    "podUid": "4e57d4ee-fd3f-44fa-8c80-1db2c6ae0e98"
  },
  "172.18.40.12": {
    "pod": "default/ippool-test-app-58b7766c7c-gw8hd",
    "podUid": "4102bd95-8f63-4f66-9b64-d7050e91b6c5"
  },
  "172.18.40.13": {
    "pod": "default/ippool-test-app-58b7766c7c-gw8hd",
    "podUid": "4102bd95-8f63-4f66-9b64-d7050e91b6c5"
  },
  "172.18.40.19": {
    "pod": "default/ippool-test-app-58b7766c7c-gw8hd",
    "podUid": "4102bd95-8f63-4f66-9b64-d7050e91b6c5"
  },
  "172.18.40.20": {
    "pod": "default/ippool-test-app-58b7766c7c-gw8hd",
    "podUid": "4102bd95-8f63-4f66-9b64-d7050e91b6c5"
  }
}

Problem 3:

Statefulset cannot be created without NICs

  Warning  FailedCreatePodSandBox  13s   kubelet            Failed to create pod sandbox: rpc error: code = Unknown desc = failed to setup network for sandbox "a0d4fe8eb1b4d9a115997df44488c4b297d5cb845234dd069f6db8decb282b98": plugin type="multus" name="multus-cni-network" failed (add): [default/test-sts-0/07793483-79f5-47ff-acdd-4a67d697ef85:macvlan-vlan100]: error adding container to network "macvlan-vlan100": spiderpool IP allocation error: [POST /ipam/ip][500] postIpamIpFailure  failed to retrieve the existing IP allocation: failed to update SpiderEndpoint allocation details NIC name net1, error: Operation cannot be fulfilled on spiderendpoints.spiderpool.spidernet.io "test-sts-0": StorageError: invalid object, Code: 4, Key: /registry/spiderpool.spidernet.io/spiderendpoints/default/test-sts-0, ResourceVersion: 0, AdditionalErrorMsg: Precondition failed: UID in precondition: 7be12fb3-6b7c-4d6f-8536-e16b924305e4, UID in object meta:

[weizhoublue]

ip == nil || ip.Address == nil 为什么代表 “ its UID %s already exists in pool ”
并且 break

这块的代码可读性 不高

[weizhoublue]

从这个 api 定义来看，为什么不是 把 分配的 ip return 出去，或者 在 相关的 return error 参数中 说明这种 case

而是用 ip为空 这种 非常有歧义的 方式来代表 ip 已经分配了

[ty-dc]

嗯。

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.85%. Comparing base (e3b8408) to head (f05a801).
Report is 16 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4359      +/-   ##
==========================================
+ Coverage   79.56%   79.85%   +0.28%     
==========================================
  Files          54       54              
  Lines        6362     6369       +7     
==========================================
+ Hits         5062     5086      +24     
+ Misses       1103     1082      -21     
- Partials      197      201       +4     

Flag	Coverage Δ
unittests	79.85% <100.00%> (+0.28%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
pkg/ippoolmanager/ippool_manager.go	84.61% <100.00%> (-2.03%)	⬇️
...orkloadendpointmanager/workloadendpoint_manager.go	100.00% <ø> (ø)

... and 1 file with indirect coverage changes