-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Total Points in player_stats return #52
Include Total Points in player_stats return #52
Conversation
…de-points-in-player-stats Fixes by autopep8 action
…om:DMcP89/yahoo_fantasy_api into enhancement/include-points-in-player-stats
Thanks for your work on this. |
@duncanduncan yes the total points is based off the scoring of the league. The point calculation is done by the Yahoo API not the library so it will always match what's listed in the Yahoo app/site |
@spilchen Can this be merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for contributing again.
I have updated the player_stats command to leverage the League resource from the Yahoo API instead of the Player resource. This allows us to return the total points and all the stats details. There are a few other benefits IMO: