Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Python 3.9 #2984

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Require Python 3.9 #2984

merged 1 commit into from
Oct 21, 2024

Conversation

soininen
Copy link
Contributor

@soininen soininen commented Oct 17, 2024

Re #2904

Checklist before merging

  • Documentation is up-to-date
  • Release notes have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black & isort
  • Unit tests pass

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.08%. Comparing base (d100b1e) to head (2fc3eb0).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
spinetoolbox/ui_main.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #2984    +/-   ##
========================================
  Coverage   67.07%   67.08%            
========================================
  Files         190      190            
  Lines       37129    37116    -13     
  Branches     5326     4457   -869     
========================================
- Hits        24905    24898     -7     
- Misses      10950    10958     +8     
+ Partials     1274     1260    -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soininen soininen merged commit 5cc2adf into master Oct 21, 2024
17 of 18 checks passed
@soininen soininen deleted the 2904_drop_python_3.8 branch October 21, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant