Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Filter action from DB editor #3007

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

soininen
Copy link
Contributor

@soininen soininen commented Nov 12, 2024

This removes the Filter icon, the associated QAction and all related code from DB editor. The action was redundant and didn't work very well.

Resolves #2820

Checklist before merging

  • Documentation is up-to-date
  • Release notes have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black & isort
  • Unit tests pass

This removes the Filter icon, the associated QAction and all
related code from DB editor.
The action was redundant and didn't work very well.
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.12%. Comparing base (9a5c21b) to head (5aa424e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3007      +/-   ##
==========================================
- Coverage   67.15%   67.12%   -0.04%     
==========================================
  Files         193      193              
  Lines       37138    37011     -127     
  Branches     4450     4443       -7     
==========================================
- Hits        24940    24843      -97     
+ Misses      10941    10913      -28     
+ Partials     1257     1255       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soininen soininen merged commit aa5c7bb into master Nov 12, 2024
18 checks passed
@soininen soininen deleted the 2820_remove_filter_action branch November 12, 2024 14:43
@manuelma
Copy link
Collaborator

I wish we could have fixed this instead of deleting it, but maybe for another day. The filter action was great to see exactly what the tool was getting after applying the filter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Activating and deactivating scenario filters in db breaks graph view
2 participants