Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(influxdb): add API token capability to InfluxDB #1059

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

belldina
Copy link

@belldina belldina commented Sep 5, 2024

Added plumbing to read apiKey from Kayenta InfluxDB and wire it to a "Token " auth header for InfluxDB API requests.
Understood that it's not elegant to simply append more args to the createClient method, but that whole piece needs a rewrite to account for various auth methods, so I'm simply tacking on for now.

@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

  • ee352ee: Add api token capability to InfluxDB, and fix

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

@belldina
Copy link
Author

belldina commented Sep 9, 2024

squashed and reformatted

@belldina
Copy link
Author

is there anything else on my side that needs to be done? I've squashed all commits and reformatted the commit title.

@belldina belldina changed the title Add api token capability to InfluxDB fix(influxdb): add API token capability to InfluxDB Sep 24, 2024
@belldina
Copy link
Author

updated the PR title to match the requests commit title format.

@jasonmcintosh
Copy link
Member

Hey sorry hadn't seen this :) HIGHLY recommend tagging people in slack - not all of us watch all the repos, though hopefully with monorepo that'll come soonish. IF can update this, I can see about reviewing & merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants