pytest migration #1213
Merged
pytest migration #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, this is huge work. Thanks a lot for this :-) |
azmeuk
force-pushed
the
pytest
branch
6 times, most recently
from
0cc5c19
to
0980d5e
Compare
TheTiz
reviewed
Aug 14, 2023
- replace setUp/tearDown with pytest fixtures - rename test classes to use the pytest convention - use pytest assertions Co-authored-by: Glandos <[email protected]>
almet
approved these changes
Aug 15, 2023
|
@Glandos can you review this? |
|
It's been one-and-a-half month so I'm going to merge this (before it gets out-of-date because of unrelated changes) |
Closed
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes #1149
closes #1148
This PR basically starts from 1149 and:
I suppose more could be done, for instance by moving away from the test class structure to a flat test files structure, and reorganize fixtures too, but maybe this is a good enough first step?