Make editing a bill into a modal #1220
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo144
force-pushed
the
modal-edit-bill
branch
from
d5f7ecb
to
37b099a
Compare
|
I agree the current UX is not good, I would also prefer having a modal. Regarding the implementation, I'm also not completely satisfied with reloading the page. Also, how does it interact with paging in the list of bills which also uses a GET parameter? @Glandos any idea for a better implementation? |
zorun
changed the title
almet
reviewed
Nov 6, 2023
| @@ -86,6 +87,25 @@ <h3 class="modal-title">{{ _('Add a bill') }}</h3> | |||
| </div> | |||
| </div> | |||
| </div> | |||
| {% if edit_bill is not none %} | |||
| <div id="bill-edit-form" class="modal fade show" role="dialog"> | |||
There was a problem hiding this comment.
what about having multiple different IDs for each of the modals here rather than sharing the same id?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
English
In short, this is a proposal to edit bills into a modal windows instead of a new html page.
Français
Bonjour à toutes et tous.
Ceci est une proposition : quand on édite une facture (en cliquant sur le crayon) plutôt que d'ouvrir une nouvelle page html cela ouvre une fenêtre modale :
But : fluidifier la navigation.
Implémentation proposée dans cette PR : quand on clique sur le crayon cela recharge la page en ajoutant "?edit_bill=X" à l'url (de la même façon qu'il existe déjà "?add_bill=True") et ouvre une modale. Cela semble bien fonctionner.
Avantage : implémentation légère, code assez simple.
Problème : ce n'est pas si fluide si la page est longue à charger et cela remonte au début de la page. Cette PR n'est donc pas parfaite.
Discussion n° 1 : Cette fonctionnalité vous paraît-elle intéressante ?
Discussion n° 2 : En l'état, est-ce mieux que rien ? Merge t'on comme ça ?
Discussion n° 3 : Comment faire mieux ?
Pour le point n° 3 je vois deux possibilités :