Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajout d'une BD explicative en anglais. #1271

Closed
wants to merge 4 commits into from

Conversation

TheodoreCouz
Copy link

--FR--
J'ai créé et ajouté une BD explicative du fonctionnement du site en version anglaise. Cette BD est basée sur la BD orginiale disponible sur le site (uniquement en version française).
J'ai modifié le code HTML pour que la BD en version anglaise soit disponible par défaut lorsque la langue selectionnée est différente du français.

--EN--
I've created and added a comic strip explaining how the site works in English. This comic is based on the original comic available on the site (French version only).
I've modified the HTML code so that the English version is available by default when the selected language is different from French.

@almet
Copy link
Member

almet commented Nov 20, 2023

Hi @TheodoreCouz, thanks for doing this, it's appreciated. That being said, it seems that you submited way too much files in this pull request (I'm not sure where they're coming from?).

If you need some help to set things up, don't hesitate to ask here for help :-)

@TheodoreCouz
Copy link
Author

It seems to be coming from Python libraries. I will resolve the issue soon. Thank you for bringing it to my attention!

@TheodoreCouz
Copy link
Author

Update: the issue with the added files is fixed.

@almet almet mentioned this pull request Nov 23, 2023
@almet
Copy link
Member

almet commented Nov 23, 2023

Hi, thanks for your work on this. I've reworked it and added changes in #1273.

Some of the pictures are a big cropped, which is not ideal, but it works.
I'm closing this in favor of the other pull request. Don't hesitate to discuss there.

@almet almet closed this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants