Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the changes requested after PR #1290 was merged. It contains only pretty minor changes.
Specifically this PR contains the following:
web.settle
route contained a "FIXME" comment. Looking into it, I think it was previously erroneously copied fromedit_bill
in web.py:811. It doesn't need to check if the bill belongs to the requested project as this function creates that bill itself.web.settle
route, however this route is already being tested inbudget_test.py:1309
,test_settle_button
. In this test, the settle route is called and checked. So no new test was added.@zorun, I think that was everything you asked back in #1290? Let me know if there is anything I missed!