Add error suppression for cases when invalid data is used for entity …

…retrieval.
spiral · Jan 8, 2024 · c077539 · c077539
1 parent f0b36a7
commit c077539
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 6 deletions.
diff --git a/src/Filter/EntityCaster.php b/src/Filter/EntityCaster.php
@@ -6,6 +6,7 @@
 
 use Cycle\ORM\ORMInterface;
 use Psr\Container\ContainerInterface;
+use Spiral\Exceptions\ExceptionReporterInterface;
 use Spiral\Filters\Exception\SetterException;
 use Spiral\Filters\Model\FilterInterface;
 use Spiral\Filters\Model\Mapper\CasterInterface;
@@ -20,6 +21,7 @@ final class EntityCaster implements CasterInterface
 
     public function __construct(
         protected readonly ContainerInterface $container,
+        protected readonly ExceptionReporterInterface $reporter,
     ) {
     }
 
@@ -34,11 +36,18 @@ public function supports(\ReflectionNamedType $type): bool
 
     public function setValue(FilterInterface $filter, \ReflectionProperty $property, mixed $value): void
     {
-        $role = $this->resolveRole($property->getType());
-        $object = $this->getOrm()->getRepository($role)->findByPK($value);
+        try {
+            $role = $this->resolveRole($property->getType());
+            $object = $this->getOrm()->getRepository($role)->findByPK($value);
+        } catch (\Throwable $e) {
+            $this->reporter->report($e);
+            throw new SetterException(previous: $e);
+        }
 
         if ($object === null && !$property->getType()->allowsNull()) {
-            throw new SetterException(message: \sprintf('Unable to find entity `%s` by primary key "%s"', $role, $value));
+            throw new SetterException(
+                message: \sprintf('Unable to find entity `%s` by primary key "%s"', $role, $value),
+            );
         }
 
         $property->setValue($filter, $object);

diff --git a/tests/src/Filter/EntityCasterTest.php b/tests/src/Filter/EntityCasterTest.php
@@ -8,6 +8,7 @@
 use Spiral\App\Database\Factory\RoleFactory;
 use Spiral\App\Database\Factory\UserFactory;
 use Spiral\Cycle\Filter\EntityCaster;
+use Spiral\Exceptions\ExceptionReporterInterface;
 use Spiral\Filters\Exception\SetterException;
 use Spiral\Tests\DatabaseTest;
 
@@ -24,7 +25,10 @@ public function testExistsRole(): void
     {
         $filter = new \ReflectionClass(RoleFilter::class);
 
-        $caster = new EntityCaster($this->getContainer());
+        $caster = new EntityCaster(
+            $this->getContainer(),
+            $this->getContainer()->get(ExceptionReporterInterface::class)
+        );
 
         $role = RoleFactory::new()->makeOne();
         UserFactory::new()->addRole($role)->createOne();
@@ -46,7 +50,10 @@ public function testNonExistRole(): void
 
         $filter = new \ReflectionClass(RoleFilter::class);
 
-        $caster = new EntityCaster($this->getContainer());
+        $caster = new EntityCaster(
+            $this->getContainer(),
+            $this->getContainer()->get(ExceptionReporterInterface::class)
+        );
 
         $property = $filter->getProperty('role');
 
@@ -59,7 +66,10 @@ public function testNonExistNullableRole(): void
     {
         $filter = new \ReflectionClass(RoleFilter::class);
 
-        $caster = new EntityCaster($this->getContainer());
+        $caster = new EntityCaster(
+            $this->getContainer(),
+            $this->getContainer()->get(ExceptionReporterInterface::class)
+        );
 
         $property = $filter->getProperty('nullableRole');