Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [CSPL-3253]: Change default storageClassName value in PVC #1417

Merged
merged 3 commits into from
Dec 20, 2024
Merged

feat: [CSPL-3253]: Change default storageClassName value in PVC #1417

merged 3 commits into from
Dec 20, 2024

Conversation

patrykw-splunk
Copy link
Collaborator

@patrykw-splunk patrykw-splunk commented Dec 16, 2024 •
edited
Loading

Addressing Github Issue #1397

Description:
This pull request changes storageClassName value from "default" to "". As a result PVC should automatically use a default storageClass configured on the cluster if value is not overwritten.

Action items:

  • Change storageClassName value from "default" to "" (empty string)

@patrykw-splunk patrykw-splunk linked an issue Dec 16, 2024 that may be closed by this pull request
Splunk Operator Helm: Default value for storageClassName should be "" instead of "default" in persistentVolumeClaim #1397
Open
vivekr-splunk
vivekr-splunk reviewed Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@vivekr-splunk vivekr-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add helm pipeline to test this

vivekr-splunk
vivekr-splunk approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@vivekr-splunk vivekr-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrykw-splunk patrykw-splunk changed the title [Draft] feat: [CSPL-3253]: Change default storageClassName value in PVC feat: [CSPL-3253]: Change default storageClassName value in PVC Dec 19, 2024
@akondur akondur merged commit 8306aea into develop Dec 20, 2024
31 checks passed
@akondur akondur deleted the feature/CSPL-3253 branch December 20, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivekr-splunk vivekr-splunk vivekr-splunk approved these changes

@akondur akondur akondur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@patrykw-splunk @akondur @vivekr-splunk