Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add delete button and UnRecruit logic #142

Merged
merged 6 commits into from
Jan 20, 2024
Merged

Add delete button and UnRecruit logic #142

merged 6 commits into from
Jan 20, 2024

Conversation

qu-bit1
Copy link
Contributor

@qu-bit1 qu-bit1 commented Sep 6, 2023

  • Deletes students from an event (Delete all & delete individually)
  • Implemented UnRecruit logic in both the delete functions

@qu-bit1
Copy link
Contributor Author

qu-bit1 commented Sep 6, 2023

fixing linting issues

1-Harshit
1-Harshit requested changes Sep 6, 2023
View reviewed changes
Copy link
Member

@1-Harshit 1-Harshit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not right flow, try to make one api EXACTLY INVERSE of register student api. For consistency and readability.

If u need more context lmk

application/admin.student.go Outdated Show resolved Hide resolved
1-Harshit
1-Harshit reviewed Dec 25, 2023
View reviewed changes
application/admin.student.go Outdated
ctx.JSON(http.StatusBadRequest, gin.H{"error": "Invalid r ID"})
return
}
if err = rc.UnRecruitStudent(ctx, studentID, rcID); err != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should only be invoked if the event is "Recruited" or "PPO" right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes fixing that and a few more things

@Krishnansh5 Krishnansh5 merged commit fd3973d into spo-iitk:main Jan 20, 2024
2 checks passed
@qu-bit1 qu-bit1 deleted the deleteAndUnrecruit branch January 23, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1-Harshit 1-Harshit 1-Harshit requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qu-bit1 @1-Harshit @Krishnansh5