Skip to content

Commit

Permalink
Merge pull request #305 from spotify/stefaniem/add-region-kubernetes-ops
Browse files Browse the repository at this point in the history
Add region and kubernetes cluster options
  • Loading branch information
live-wire authored Jul 27, 2023
2 parents 31b7063 + e0f03a7 commit c1f105d
Show file tree
Hide file tree
Showing 4 changed files with 103 additions and 67 deletions.
146 changes: 82 additions & 64 deletions gen/pb-go/flyteidl-flink/flink.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions gen/pb-go/flyteidl-flink/flink.pb.validate.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 15 additions & 3 deletions gen/pb-protodoc/flyteidl-flink/flink.proto.rst
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,8 @@ Custom Proto for Flink Plugin.
"image": "...",
"flinkVersion": "...",
"parallelism": "...",
"kubernetesClusterName": "...",
"kubernetesClusterRegion": "...",
"jflyte": "{...}"
}
Expand Down Expand Up @@ -279,6 +281,16 @@ flinkVersion
parallelism
(`int32 <https://developers.google.com/protocol-buffers/docs/proto#scalar>`_)

.. _api_field_flyteidl_flink.FlinkJob.kubernetesClusterName:

kubernetesClusterName
(`string <https://developers.google.com/protocol-buffers/docs/proto#scalar>`_)

.. _api_field_flyteidl_flink.FlinkJob.kubernetesClusterRegion:

kubernetesClusterRegion
(`string <https://developers.google.com/protocol-buffers/docs/proto#scalar>`_)

.. _api_field_flyteidl_flink.FlinkJob.jflyte:

jflyte
Expand All @@ -293,7 +305,7 @@ jflyte
flyteidl_flink.JobExecutionInfo
-------------------------------

`[flyteidl_flink.JobExecutionInfo proto] <https://github.com/lyft/flyteidl/blob/master/protos/flyteidl-flink/flink.proto#L72>`_
`[flyteidl_flink.JobExecutionInfo proto] <https://github.com/lyft/flyteidl/blob/master/protos/flyteidl-flink/flink.proto#L74>`_


.. code-block:: json
Expand All @@ -314,7 +326,7 @@ id
flyteidl_flink.JobManagerExecutionInfo
--------------------------------------

`[flyteidl_flink.JobManagerExecutionInfo proto] <https://github.com/lyft/flyteidl/blob/master/protos/flyteidl-flink/flink.proto#L74>`_
`[flyteidl_flink.JobManagerExecutionInfo proto] <https://github.com/lyft/flyteidl/blob/master/protos/flyteidl-flink/flink.proto#L76>`_


.. code-block:: json
Expand All @@ -335,7 +347,7 @@ ingressURLs
flyteidl_flink.FlinkExecutionInfo
---------------------------------

`[flyteidl_flink.FlinkExecutionInfo proto] <https://github.com/lyft/flyteidl/blob/master/protos/flyteidl-flink/flink.proto#L76>`_
`[flyteidl_flink.FlinkExecutionInfo proto] <https://github.com/lyft/flyteidl/blob/master/protos/flyteidl-flink/flink.proto#L78>`_


.. code-block:: json
Expand Down
2 changes: 2 additions & 0 deletions protos/flyteidl-flink/flink.proto
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@ message FlinkJob {
string image = 8;
string flinkVersion = 9;
int32 parallelism = 10 [ (validate.rules).int32.gte = 0 ];
string kubernetesClusterName = 11;
string kubernetesClusterRegion = 12;

// if using experiment flytekit-java this will contain all artifacts required
// to run the task
Expand Down

0 comments on commit c1f105d

Please sign in to comment.