Add tempo support #172
Add tempo support #172
Conversation
|
@psobot Trying to make a bit more progress on this. The method I found in Juce seems to be setBpm and getBpm. |
|
@psobot When you have time, I'd love to hear your feedback on this |
| def __set_extra_functions__(self, tempo_bpm: int = 120): | ||
| tempo_bpm = self.tempo_bpm | ||
|
|
There was a problem hiding this comment.
This won't do anything: tempo_bpm is just a local variable. I think you probably want to pass tempo_bpm through as a parameter into _VST3Plugin.__init__(self, path_to_plugin_file, plugin_name) on line 682 instead.
| @@ -994,9 +995,10 @@ inline void init_external_plugins(py::module &m) { | |||
| "(i.e.: if you're running Linux but trying to open a VST that does not " | |||
| "support Linux, this will fail).") | |||
| .def(py::init([](std::string &pathToPluginFile, | |||
| std::optional<std::string> pluginName) { | |||
| std::optional<std::string> pluginName, | |||
| std::optional<int> tempoBpm) { | |||
There was a problem hiding this comment.
I think we'll need to decide if tempoBpm can be optional or not; in your Python code below, you pass a default value of 120 BPM. Making tempoBpm an std::optional here means that it could be None as well; it sounds like it should be mandatory argument with a default value, rather than an optional type.
Co-authored-by: Peter Sobot <[email protected]>
|
Please add this functionality to the master branch of Pedalboard! We can't use delays, reverbs as well as some synths which have synchronization with host tempo. |
Just wanted to throw in my support for this. If we could somehow set a global bpm variable it would push this into overdrive and open up ALOT of options given so many vst makers default to vst host sync and don't offer any manual control |
In reference to #158
@psobot Could you let me know if I'm going in the right direction with this? My c++ knowledge is rusty.