-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement fluent interface #361
Open
fpdrozd
wants to merge
15
commits into
main
Choose a base branch
from
feat/fluent-interface
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the fluent interface implementation proposed here.
The
Client class
has been moved from the core package to the corresponding SDK packages because of typescript's problems with inferring the endpoint types when they were being appended dynamically (they have to be specifically bound tothis.
).All the types responsible for fluent interface functionality will stay in the
sdk-core
, this way we can go ahead and simply implement it in thePlatform SDK
.WithClientBuilderOptions type
Now the type supports passing a union of required props names which results in checking if at least one of them is satisfied. This behavior is meant for the endpoints that require either
bearer_token
ororder_token
.Example:
Examples
Because of the feature's backwards compatibility the SDK can be used as before:
With the new fluent interface approach (since
bearer_token
is the only required optionaccountInfo
options can be skipped completely when provided with the token bywithBearerToken
):Otherwise, if the token is not provided, we get a compilation error: