Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supports derived delete for JDBC (rebased) #1486

Closed
wants to merge 1 commit into from
Closed

Supports derived delete for JDBC (rebased) #1486

wants to merge 1 commit into from

Conversation

nkonev
Copy link
Contributor

@nkonev nkonev commented Apr 8, 2023

It is rebased version of #230

I saw #230 (review), seems they were met by the original author.

PTAL @schauder

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 8, 2023
@nkonev nkonev changed the title Supports derived delete (rebased) Supports derived delete for JDBC (rebased) Apr 8, 2023
@nkonev
Copy link
Contributor Author

nkonev commented Apr 19, 2023 •
edited
Loading

@schauder do you have chance to take a look ?

@nkonev
Copy link
Contributor Author

nkonev commented Apr 24, 2023

@mp911de PTAL

@schauder
Copy link
Contributor

I have this on my radar and will take a closer look once the next GA release is out, since I won't merge a change like this into a RC either way.

Thanks for rebasing this.

@schauder schauder added the in: jdbc Spring Data JDBC label Apr 24, 2023
@schauder schauder self-assigned this Apr 24, 2023
@nkonev
Copy link
Contributor Author

nkonev commented May 29, 2023

According to calendar.spring.io there are roughly two weeks to the nearest Spring Data release.
I'm worried that this PR won't be there.

Do you have a chance to review and merge ?
@schauder @mp911de

@nkonev
Copy link
Contributor Author

nkonev commented Jul 8, 2023

Hello!
I think it's an useful thing, let's pull it in

@schauder @mp911de

schauder added a commit that referenced this pull request Jul 21, 2023
@schauder
Introduce AggregatePath.
d00e928 
AggregatePath replaces PersistentPropertyPathExtension.
It gets created and cached by the RelationalMappingContext, which should be more efficient and certainly looks nicer.

Closes #1525
Original pull request #1486
@leshalv leshalv mentioned this pull request Dec 5, 2023
Closed
@leshalv
Copy link

leshalv commented Feb 4, 2024

Is there any progress on the plan?
@schauder

@leshalv leshalv mentioned this pull request Feb 4, 2024
Closed
@schauder schauder mentioned this pull request Sep 23, 2024
Closed
schauder pushed a commit that referenced this pull request Dec 18, 2024
@nkonev @schauder
Support derived delete.
1515a3a 
Closes #771
See #230
Original pull request #1486
schauder added a commit that referenced this pull request Dec 18, 2024
@schauder
Polishing.
73d6788 
Fix merge problems.

Execute tests only for HsqlDb.

Refactoring to use lists instead of streams.
We try to avoid the latter, since they are prone to cause performance issues.

Minor refactorings.

See #771
See #230
Original pull request #1486
@schauder schauder added this to the 3.5 M1 (2025.0.0) milestone Dec 18, 2024
@schauder schauder added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 18, 2024
@schauder
Copy link
Contributor

Thanks to everyone. This is now finally merged, and polished.

@schauder schauder closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@schauder schauder

Labels
in: jdbc Spring Data JDBC type: enhancement A general enhancement
Projects
None yet
Milestone
3.5 M1 (2025.0.0)
Development

Successfully merging this pull request may close these issues.
4 participants
@nkonev @schauder @leshalv @spring-projects-issues