Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dependency properties. #1892

Closed
wants to merge 2 commits into from
Closed

Conversation

schauder
Copy link
Contributor

Moves version properties for R2DBC drivers to parent so they get detected by the release tooling.

Moves version properties for R2DBC drivers to parent so they get detected by the release tooling.
@schauder schauder requested a review from mp911de September 18, 2024 14:29
schauder added a commit to spring-projects/spring-data-release that referenced this pull request Sep 18, 2024
The R2DBC dependencies are only found if they are defined in spring-data-relational, which is done by spring-projects/spring-data-relational#1892
mp911de pushed a commit to spring-projects/spring-data-release that referenced this pull request Sep 19, 2024
The R2DBC dependencies are only found if they are defined in spring-data-relational, which is done by spring-projects/spring-data-relational#1892

Closes #97
Copy link
Member

@mp911de mp911de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All POM's got reformatted with spaces as indents instead of tabs. Care to have a look?

Also, we should backport these changes to our supported versions.

@mp911de mp911de added the type: task A general task label Sep 19, 2024
@mp911de mp911de added this to the 3.2.11 (2023.1.11) milestone Sep 19, 2024
schauder added a commit that referenced this pull request Sep 23, 2024
Moves version properties for R2DBC drivers to parent so they get detected by the release tooling.

Original pull request #1892
schauder added a commit that referenced this pull request Sep 23, 2024
Moves version properties for R2DBC drivers to parent so they get detected by the release tooling.

Original pull request #1892
schauder added a commit that referenced this pull request Sep 23, 2024
Moves version properties for R2DBC drivers to parent so they get detected by the release tooling.

Original pull request #1892
@schauder
Copy link
Contributor Author

All POM's got reformatted with spaces as indents instead of tabs. Care to have a look?

Fixed. It was only one POM, though.

Also, we should backport these changes to our supported versions.

Done.

@schauder schauder closed this Sep 23, 2024
@schauder schauder deleted the issue/move-r2dbc-properties branch November 11, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants