Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added fetchSize to ReactiveSelectOperationSupport #1898

Closed
wants to merge 1 commit into from
Closed

Added fetchSize to ReactiveSelectOperationSupport #1898

wants to merge 1 commit into from

Conversation

mipo256
Copy link
Contributor

@mipo256 mipo256 commented Sep 26, 2024

Solves #1652 issue.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 26, 2024
mp911de
mp911de reviewed Sep 30, 2024
View reviewed changes
...ng-data-r2dbc/src/main/java/org/springframework/data/r2dbc/core/ReactiveSelectOperation.java Outdated
* @param fetchSize
* @return
*/
SelectWithQuery<T> withFetchSize(Integer fetchSize);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be a primitive.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree

Copy link
Contributor Author

@mipo256 mipo256 Sep 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mp911de That is done. I hope we both understand, that in general, this does not omit the boxing from int to Integer. Although, specifying withFetchSize(null) still does not make much sense, since that signals the driver to adhere to default.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We apply defaults whenever user input is absent. Asking for applying default behavior is weird in the first place.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's exactly what I'm trying to communicate, I'm just verifying we're on the same page.

@mp911de mp911de self-assigned this Sep 30, 2024
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 30, 2024
@mipo256 mipo256 requested a review from mp911de September 30, 2024 12:49
@mp911de mp911de changed the title GH-1652 Added fetchSize to ReactiveSelectOperationSupport Added fetchSize to ReactiveSelectOperationSupport Oct 1, 2024
mp911de pushed a commit that referenced this pull request Oct 1, 2024
@mipo256 @mp911de
Add fetchSize to ReactiveSelectOperationSupport.
96a4121 
Closes #1652
Original pull request: #1898
mp911de added a commit that referenced this pull request Oct 1, 2024
@mp911de
Polishing.
90b6d8e 
Use FilterFunction instead of nullable fetchSize to avoid unconditional capturing lambdas and improve defaulting.

Add since tag.

See #1652
Original pull request: #1898
@mp911de
Copy link
Member

mp911de commented Oct 1, 2024

Thank you for your contribution. That's merged and polished now.

@mp911de mp911de closed this Oct 1, 2024
@mp911de mp911de added this to the 3.4 RC1 (2024.1.0) milestone Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mp911de mp911de Awaiting requested review from mp911de

Assignees

@mp911de mp911de

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.4 RC1 (2024.1.0)
Development

Successfully merging this pull request may close these issues.
3 participants
@mipo256 @mp911de @spring-projects-issues