Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tremulous spinning icons #39

Closed
termim opened this issue Feb 8, 2016 · 7 comments · Fixed by #202
Closed

Tremulous spinning icons #39

termim opened this issue Feb 8, 2016 · 7 comments · Fixed by #202

Comments

@termim
Copy link

termim commented Feb 8, 2016

I noticed that all spinning icons do shake a little while rotating.
Is there a way to make it smooth as on the original web page?

@SylvainCorlay
Copy link
Member

Did you notice this on the animated gif or while running the demo?

@termim
Copy link
Author

termim commented Feb 9, 2016

While running the demo on linux

On Mon, Feb 8, 2016 at 6:27 PM, Sylvain Corlay [email protected]
wrote:

Did you notice this on the animated gif or while running the demo?


Reply to this email directly or view it on GitHub
#39 (comment)
.

Mikhail Terekhov

@goanpeca goanpeca modified the milestone: 0.4 Oct 13, 2016
@ccordoba12 ccordoba12 modified the milestones: 0.4, v0.5 Dec 30, 2016
@boredstiff
Copy link

Hi, I'm still seeing this issue, running 0.4.4 on Windows.

        self.loading_button = QtGui.QPushButton()
        self.loading_icon = qtawesome.icon(
            'fa.spinner', animation=qtawesome.Spin(self.loading_button))
        self.loading_button.setIcon(self.loading_icon)

Using this, the spinning icons does indeed spin, but shakes while it's rotating - kind of a bummer, because this was the only icon I needed from the package.

Is there anything that has been done to address this?

@boredstiff
Copy link

shaking

It actually shakes faster than this, my recording was only recording at 15fps.

It also isn't just that single icon (fa.spinner), it's any icon.

@ccordoba12 ccordoba12 removed this from the v0.5 milestone Sep 12, 2018
@doudz
Copy link
Contributor

doudz commented Oct 24, 2019

I have the same problem on Ubuntu,
I think it has something to do with alignment

https://github.com/spyder-ide/qtawesome/blob/master/qtawesome/iconic_font.py#L162

Because if I replace
painter.drawText(rect, Qt.AlignCenter | Qt.AlignVCenter, char)
by
painter.drawText(rect, 0, char)
icons are not shaking anymore but rotate eccentric

I suppose somewhere there's a rounding or something treats as int instead of float

as a workaround I increased the rotating speed (step=10) so the shaking is not visible

@goanpeca
Copy link
Member

as a workaround I increased the rotating speed (step=10) so the shaking is not visible

This is the only solution I can see so far :-\

Looks ok on Mac

@listyque
Copy link
Contributor

What if render it larger and downscale icon?
Render 128*128 / 4
The only reason animation is useless - shaking and buggy looks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants