PR: Disable font hinting to mitigate tremulous spinning to some extent #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalthviz
reviewed
Feb 28, 2022
| @@ -140,7 +140,10 @@ def _paint_icon(self, iconic, painter, rect, mode, state, options): | |||
| if animation is not None: | |||
| animation.setup(self, painter, rect) | |||
|
|
|||
| painter.setFont(iconic.font(prefix, draw_size)) | |||
| font = iconic.font(prefix, draw_size) | |||
| if animation is not None: | |||
There was a problem hiding this comment.
Could you add a comment here referencing the issue?
There was a problem hiding this comment.
I added the comment "Disable font hinting to mitigate tremulous spinning to some extent".
Is it as expected?
There was a problem hiding this comment.
That sounds good 👍 it's just missing the addition of something like See spyder-ide/qtawesome#39 at the end
There was a problem hiding this comment.
I added more See spyder-ide/qtawesome#39 at the end.
dalthviz
changed the title
dalthviz
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @dalthviz.
This PR is to mitigate #39 to some extent.
As #202 (comment), the method using QRawFont and QPainterPath does not support all fonts supported by QFont.
So, I think the method is optional.
Even if QFont is used, by disabling font hinting, the tremulous spinning seems to be mitigated to some extent.
So, I think it is better that the font hinting is disabled as default when animation.
left: default (enable) hinting, right: disable hinting
