Support separate alt text and captions in Markdown content #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er support for Alt text from markdown besides caption text
✅ Deploy Preview for spyder-svelte-website-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
CAM-Gerlach
reviewed
Sep 17, 2024
There was a problem hiding this comment.
LGTM, except that the captions are retained in the alt text field. Simply leaving it empty would be a better alternative, as it avoids repeating the same thing twice that does not replace or describe the actual content of the image.
Given there are a relatively small number of them and they are being modified anyway, I just went ahead and wrote alt text for them, leaving it as suggestions you can apply.
Co-authored-by: C.A.M. Gerlach <[email protected]>
Co-authored-by: C.A.M. Gerlach <[email protected]>
Co-authored-by: C.A.M. Gerlach <[email protected]>
Co-authored-by: C.A.M. Gerlach <[email protected]>
Co-authored-by: C.A.M. Gerlach <[email protected]>
Co-authored-by: C.A.M. Gerlach <[email protected]>
Co-authored-by: C.A.M. Gerlach <[email protected]>
Co-authored-by: C.A.M. Gerlach <[email protected]>
Co-authored-by: C.A.M. Gerlach <[email protected]>
…d in the alt text of an image
… part of the experiments to fix the issue with double quotes, and it's interfering with metadata fields from the blog posts in the build process. Will investigate further
CAM-Gerlach
changed the title
rehype-figure with rehype-title-figure
CAM-Gerlach
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces a plugin to add support for proper Alt text from markdown sources using mdsvex. The new plugin is
rehype-title-figure.With this new implementation,
will render like<figure><img src="image.jpg" alt="This is alt text" title="This is the caption"/><figcaption>This is the caption</figcaption></figure>.An image without a caption will not produce a
figurenorfigcaption, but will produce animgwith an alt attribute:will render like<img src="image.jpg" alt="This is alt text" />.