Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] remove unnecessary pkgs in Dockerfile #41

Closed
wants to merge 1 commit into from

Conversation

weiguoz
Copy link
Collaborator

@weiguoz weiguoz commented May 17, 2019

fix #40

@typhoonzero
Copy link
Collaborator

We should update sqlflow to not use this image directly first before removing these deps: https://github.com/sql-machine-learning/sqlflow/blob/develop/.travis.yml#L33

@tonyyang-svail
Copy link
Contributor

COPY dataset/create_model_db.sql /dataset/create_model_db.sql

Should also be reverted.

Note: if you wanna undo a commit message (7240393 ) by appending a new commit with the resulting inverse content, try git revert. ref

- remove crete_model_db.sql
@weiguoz weiguoz changed the title remove unnecessary pkgs in Dockerfile [WIP] remove unnecessary pkgs in Dockerfile May 17, 2019
Copy link
Collaborator

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with @weiguoz I'll try to put hive server container at background in CI, so that we can remove deps here.

@tonyyang-svail
Copy link
Contributor

Duplicated with #42. Since this PR is titled with WIP, I choose to close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dockerfile shouldn't include requirement of SQLFlow
3 participants