Add several tools for release #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typhoonzero
reviewed
Nov 29, 2019
| @@ -7,8 +7,9 @@ | |||
| <groupId>org.sqlflow</groupId> | |||
| <artifactId>jsqlflow</artifactId> | |||
| <packaging>jar</packaging> | |||
| <version>1.0-SNAPSHOT</version> | |||
| <version>0.0.1</version> | |||
There was a problem hiding this comment.
maybe the version start from 0.1.0?
There was a problem hiding this comment.
Agree.
The pb is being iterated. Let's update the version to 0.1.0 when the protocol is stabled.
Yancey1989
reviewed
Nov 29, 2019
| @@ -7,8 +7,9 @@ | |||
| <groupId>org.sqlflow</groupId> | |||
There was a problem hiding this comment.
Just confusion about the groupId field, should it be sqlfow.org ?
weiguoz
commented
Nov 29, 2019
| - mvn clean verify --batch-mode --errors --fail-at-end --show-version -DinstallAtEnd=true | ||
| install: mvn clean verify -Dgpg.skip | ||
|
|
||
| # TODO(weiguo) not tested yet |
There was a problem hiding this comment.
In fact, it will fail to run the script mvn ... due to the incorrect gpg configuration.
I left an issue #13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add several tools like(gpg,javadoc..) to release the pkg to sonatype.org central