Test background hive server #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typhoonzero
changed the title
wangkuiyi
previously approved these changes
May 21, 2019
| @@ -30,7 +30,8 @@ script: | |||
| - docker build -t sqlflow:latest -f Dockerfile . | |||
| - docker run --rm -v $GOPATH/src:/go/src -w /go/src/github.com/sql-machine-learning/sqlflow sqlflow:latest pre-commit run -a | |||
| - docker run --rm -v $GOPATH:/go -w /go/src/github.com/sql-machine-learning/sqlflow sqlflow:latest bash scripts/test.sh | |||
| - docker run --rm -v $GOPATH:/go -w /go/src/github.com/sql-machine-learning/sqlflow sqlflow/gohive:dev bash scripts/test_hive.sh | |||
| - docker run -d --name=hive -p 10000:10000 -p 10002:10002 -p 8040:8040 -p 8042:8042 -p 9864:9864 -p 9866:9866 -p 9867:9867 -p 9870:9870 -p 8020:8020 -p 8899:8899 sqlflow/gohive:dev python3 -m http.server 8899 | |||
There was a problem hiding this comment.
Can we move these very long commands into a shell script file so we could have a chance to write comments explaining like why we'd export ports like 10002, 8040, 9846, 9866, and 9867?
There was a problem hiding this comment.
Added comments in .traivs.yml
tonyyang-svail
approved these changes
May 22, 2019
| sleep 5 | ||
| fi | ||
| done | ||
|
|
There was a problem hiding this comment.
Since we are switching back to sqlflow/sqlflow:latest, the following lines can be removed.
set -e
. /miniconda/etc/profile.d/conda.sh
source activate sqlflow-dev
There was a problem hiding this comment.
Thanks, will clean up in next PR.
weiguoz
approved these changes
May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: sql-machine-learning/gohive#40