Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix USB enumeration #28

Merged
merged 3 commits into from
May 11, 2023
Merged

Fix USB enumeration #28

merged 3 commits into from
May 11, 2023

Conversation

vigmat28
Copy link
Contributor

Resolve #27

squat
squat reviewed May 10, 2023
View reviewed changes
deviceplugin/usb.go Outdated Show resolved Hide resolved
squat
squat reviewed May 10, 2023
View reviewed changes
deviceplugin/usb.go Outdated Show resolved Hide resolved
squat
squat reviewed May 10, 2023
View reviewed changes
Copy link
Owner

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this contribution @vigmat28 :))))
I left a couple of comments and questions. Please take a look when you can

squat
squat approved these changes May 11, 2023
View reviewed changes
Copy link
Owner

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks :)))

squat
squat reviewed May 11, 2023
View reviewed changes
deviceplugin/usb.go Outdated Show resolved Hide resolved
@squat squat merged commit c0383bb into squat:main May 11, 2023
@squat
Copy link
Owner

squat commented Jun 7, 2023 •
edited
Loading

Another thing to note is that this enhancement will also reduce memory usage of the device plugin whenever USB discovery is disabled.

xref: #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squat squat squat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

USB discovery error
2 participants
@vigmat28 @squat