Add warnings to output for alpha levels in contrast check #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Three complications with calculating the "flattened" (non-alpha) representation of font color and background color are: * determining what is actually behind the text - elements may be positioned with css such that it's very hard to determine what element is the background of some or all of the text * the css opacity element may introduce further aspects of transparency * transparent background can reveal images where contrast cannot be calculated
|
Thanks for this PR @phillbaker. I've made a few modifications and tested it out, seems to work well with the exception of some quirks with the unit test (I think phantomJS related because they work fine in the browser). |
|
Thanks! Any chance of getting a release soon to include this? |
|
I'll put it on the radar, but it won't be this week (The current build process is quite time consuming and I need to allocate a decent slice to it). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #134 and the discussion there.
This is the initial PR, based on #134, to detect apha in either font text color or background color and issue a warning. It squashes all of the commits in #134 into one commit and adds a commit to focus the scope of the PR on just issuing warnings.
Three complications with calculating the "flattened" (non-alpha) representation of font color and background color discussed in #134 are:
It looks like a couple of other fixes were originally included in #134 that I left in that we can pull out into separate PRs if they're desired:
This PR also adds an example to the test contrast html file.