Added Keyed Return for SeriesStats #115
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -227,7 +227,15 @@ class TimeSeriesRDD[K](val index: DateTimeIndex, parent: RDD[(K, Vector)]) | |||
| * Gets stats like min, max, mean, and standard deviation for each time series. | |||
| */ | |||
| def seriesStats(): RDD[StatCounter] = { | |||
| map(kt => new StatCounter(kt._2.valuesIterator)) | |||
| map(kt => new StatCounter(kt._2.valuesIterator)) | |||
There was a problem hiding this comment.
Thinking about it now, I think it actually makes sense to include the keys with the stats in all cases, i.e. to just change the return type of seriesStats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SeriesStats would drop the key for the series when returning. Including this key can be useful for subsequent joins.