-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Holt-Winters seasonal method #142
Conversation
Marking ARXModel class as serializable
… scala BOBYQA n CMAES, forecast remaining
…t R.Multiplicative and CMAES remaining.
This looks awesome. Thanks a ton. Curious to hear any details of the R comparison? The error tends to be higher than R? How much higher? Can still accept the PR if so, just want to be able to document this properly. A few notes:
Are you interested in fixing these things? If not, let me know, and I can work on them when I get the chance. |
Why does the forecast method receive two vectors? Isn't better to create the forecast vector inside this method? |
Ok, but don't you think that would be better to maintain the same structure than is in ARIMA? |
you are a champion. This looks great. The main nits I have are cosmetic:
Let me know if you're interested in making these changes. If not, I'll happily do so. |
No description provided.