Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

del: barber deletion #6262

Open
wants to merge 3 commits into
base: master220
Choose a base branch
from

Conversation

Etrnlmelancholy
Copy link
Contributor

@Etrnlmelancholy Etrnlmelancholy commented Dec 21, 2024

Описание

Removes the Barber role, removes barber related code, and removes safety scissors from the traitor pool item.
Thanks to FlitchTime for barbershop removal on maps

Причина создания ПР / Почему это хорошо для игры

Ok ok, before everyone starts dropping their improve not removes and negative ratings on this PR, id like to at least pitch the idea first and give you some things to think about. An explanation why this role is so poorly designed and flawed.

Firstly,
its a bad role. I have constantly heard people use the defense of Barber being a """rp role""" in which its job is to make social interactions and roleplay as a barber. But I think that's a flawed argument, and it is very hollow when inspected closer. All roles are RP roles, you roleplay as the job you have chosen, and while some jobs are more dialogue oriented with others being more pressure focus, it is still roleplaying as the job you've chosen.

When you compare it to other roles barber lacks an actual excuse to exist alongside jobs that actually provide to the station. Security catches antagonist and works to enforce law, Chefs cook food and run kitchens and make dishes of variety, Doctors heal people, preform surgery, and provide medicine, etc etc. So what does Barber do? They cut hair. An incredibly niche, flawed, and boring field that is completely outclassed by a single object.

Secondly,
mirrors make the barber role obsolete. There is no question that everyone who has played or has experience knows that mirrors are the optimal way to get your hair back after any incident you lose them in. The process of going to a barber to get a haircut or something of the like is an issue of too many moving parts for something the mirror simplifies.

I have only seen people to go barbers either from being close friends with the player who cuts hair, or because its a green shift and people are bored out of their minds for anything to do. The issue with Barber's moving parts is the player themselves, and when it comes to getting your hair back most people do not want to spend five minutes with a player when they can do it in 10 seconds.

Thirdly,
there is zero content for barber. Like I've said previously, there is no depth or variety to the role, you simply cut hair and occasionally dye it. The only content most people know about is its traitor items, which are rather gimmicky in their purpose and serve more as surplus filler than anything else. For the years it has existed, the role has been a meme or joke of new players picking it and going around griefing people in the bar, or acting as just another assistant.

That issue stems from its lack of content, as its very fast and easy to get bored of such a role with absolutely no gameplay loop. There are a handful of people who try to make the most of barber but that pool is so tiny that is hard to justify keeping it for such a small count of people.

Lastly,
barbers history stems back January 16th, 2014 8:42 AM. In the same era when Paradise began and Karma was introduced into the game. Karma was flawed, and many of the roles that were Karma locked were and still are inherently flawed to the overall game. Either from being too incredibly niche, or lacking any sort of meaningful content. Barber is both those. And if people ask why we should remove it when we can optionally improve it, I ask. Why hasn't anyone bothered to improve this role for 10 YEARS?

It has been in a very similar state to its original design since 2014, and not a single person during the many eras of Paradise has bothered to make it all interesting or meaningful. I think we are past that time, and instead of preaching a non productive mantra, we should do what is healthy for the game and remove poor, badly designed bloats job from a younger era of Paradise, just like Karma.

As a great host once said, that I absolutely agree with, quote,

aa07 | Im competent I promise — 03/01/2022 11:45 AM
barber is the perfect example of a role that was shoehorned in
it has no purpose

https://discord.com/channels/617003227182792704/755125334097133628/1318669846652649534

Демонстрация изменений

image

Тесты

image
image

@Etrnlmelancholy Etrnlmelancholy requested a review from a team as a code owner December 21, 2024 18:00
@Etrnlmelancholy
Copy link
Contributor Author

OctusGit герой

@github-actions github-actions bot added the MAP Affects map label Dec 21, 2024
@Etrnlmelancholy Etrnlmelancholy changed the title barber deletion del: barber deletion Dec 21, 2024
@FlitchTime
Copy link
Contributor

Копипаста пасты :GAGAGA

@SAADf603
Copy link
Contributor

AA07 be like
image

SAADf603
SAADf603 previously approved these changes Dec 23, 2024
Copy link
Member

@Daeberdir Daeberdir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вернуть лендмарки, вернуть код роли, но вывести из джобок.

@Daeberdir Daeberdir added the Do Not Merge Либо не прошла предложка, либо кто-то не доволен. label Dec 25, 2024
@ss220-space ss220-space deleted a comment from Etrnlmelancholy Dec 25, 2024
@Daeberdir
Copy link
Member

Либо делаешь нормально, либо не делаешь.

@ss220-space ss220-space deleted a comment from Etrnlmelancholy Dec 25, 2024
@BeebBeebBoob
Copy link
Member

Вернуть лендмарки, вернуть код роли, но вывести из джобок.

Либо читаешь предложу сперва и условия либо не проверяй вовсе.
Сказано, удалить все к хуям, значит все. И лендмарки и другие Барбер вещи связанные.
Отменяю вето. Let the man cook PR.

@BeebBeebBoob BeebBeebBoob removed the Do Not Merge Либо не прошла предложка, либо кто-то не доволен. label Dec 25, 2024
@SAADf603
Copy link
Contributor

На всякий поясню: удалять барбер зону пока не стоит, потому что ивент карты всё ещё остаются с комнатой барбера. Я исправлю это позже в рефакторе зон

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MAP Affects map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants